gh-123471: Make concurrent iteration over itertools.permutations and itertools.combinations_with_replacement thread-safe #144402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colesbury
reviewed
Feb 2, 2026
colesbury
added
needs backport to 3.14
colesbury
reviewed
Feb 2, 2026
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
Overall, looks good to me. I left a comment about the test above.
Would you please also add a news entry?
eendebakpt
commented
Feb 3, 2026
Misc/NEWS.d/next/Library/2026-02-03-08-50-58.gh-issue-123471.yF1Gym.rst
Outdated
Show resolved
Hide resolved
|
Thanks @eendebakpt for the PR, and @colesbury for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @eendebakpt and @colesbury, I could not cleanly backport this to |
Contributor
|
Hmmm... are we backporting these sorts of PRs to 3.14 or no? It looks like some of the other ones are 3.15 only. |
encukou
pushed a commit
to encukou/cpython
that referenced
this pull request
Feb 5, 2026
…ns` and `itertools.combinations_with_replacement` thread-safe (pythongh-144402)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use a critical section similar to the approach in #132814.